Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Builder: Featured pages component #357

Closed
leandrocp opened this issue Oct 10, 2023 · 1 comment · Fixed by #389
Closed

Page Builder: Featured pages component #357

leandrocp opened this issue Oct 10, 2023 · 1 comment · Fixed by #389
Assignees
Labels
enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors
Milestone

Comments

@leandrocp
Copy link
Contributor

leandrocp commented Oct 10, 2023

Currently the featured blog posts section in the dockyard.com website (screenshot below) is managed by a custom database table and custom code but we want to expose that kind of content as a reusable component that will look like:

<BeaconWeb.Components.featured_pages />

That component can receive an source argument that is a function used to return a list of pages. It should be optional and the default implementation should be Content.list_pages(site, per_page: 3, sort: :updated_at)

site can be fetched from the live view process, see

assigns = Map.put(assigns, :beacon_site, Process.get(:__beacon_site__))

Screenshot 2023-10-10 at 10 30 56 AM
@leandrocp leandrocp added proposal proposal Idea in research phase enhancement New feature or improvement labels Oct 10, 2023
@leandrocp leandrocp moved this to Todo in Beacon Oct 20, 2023
@AZholtkevych AZholtkevych moved this from Todo to Backlog in Beacon Oct 23, 2023
@leandrocp leandrocp changed the title Page Builder - Featured pages component Page Builder: Featured pages component Nov 1, 2023
@leandrocp leandrocp added good first issue Good for newcomers help wanted Looking for contributors and removed proposal Idea in research phase proposal labels Nov 1, 2023
@leandrocp leandrocp moved this from Backlog to Todo in Beacon Nov 1, 2023
@edborsa
Copy link
Contributor

edborsa commented Dec 21, 2023

Hey, I created a PR for this one ;)

#388

@AZholtkevych AZholtkevych linked a pull request Jan 11, 2024 that will close this issue
@AZholtkevych AZholtkevych moved this from Todo to In Progress in Beacon Jan 11, 2024
@AZholtkevych AZholtkevych added this to the v0.1.0 milestone Feb 2, 2024
@AZholtkevych AZholtkevych moved this from In Progress to Done in Beacon Feb 5, 2024
@AZholtkevych AZholtkevych mentioned this issue Apr 21, 2024
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants