Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add adjusts for the User defined Components #535

Merged
merged 14 commits into from
Jul 12, 2024
Merged

Add adjusts for the User defined Components #535

merged 14 commits into from
Jul 12, 2024

Conversation

alexandrexaviersm
Copy link
Collaborator

@alexandrexaviersm alexandrexaviersm commented Jun 27, 2024 •
edited
Loading

Necessary adjusts that came up after doing more work in the UI:

  • Create a new field in beacon_component_attrs to save the struct name of a attribute of type struct
  • Create new context functions for ComponentAttr

@alexandrexaviersm alexandrexaviersm self-assigned this Jun 28, 2024
@alexandrexaviersm alexandrexaviersm changed the title Add adjusts for the Component Attribute context Add adjusts for the User defined Components Jun 28, 2024
leandrocp
leandrocp requested changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@leandrocp leandrocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a few comments

lib/beacon/content.ex Outdated Show resolved Hide resolved
lib/beacon/content.ex Outdated Show resolved Hide resolved
lib/beacon/content.ex Outdated Show resolved Hide resolved
test/support/migrations/20240621085408_add_struct_name_to_beacon_component_attrs.exs Outdated Show resolved Hide resolved
@alexandrexaviersm
Copy link
Collaborator Author

@leandrocp it looks like Beacon.Migration was only running the migration v001. So I made some adjusts to it

@leandrocp
Copy link
Contributor

@leandrocp it looks like Beacon.Migration was only running the migration v001. So I made some adjusts to it

Sorry I forgot to mention you have to bump the version here

beacon/lib/beacon/migration.ex

Line 6 in ffbfb3d

@latest Beacon.Migrations.V001

@alexandrexaviersm
Copy link
Collaborator Author

@leandrocp it looks like Beacon.Migration was only running the migration v001. So I made some adjusts to it

Sorry I forgot to mention you have to bump the version here

beacon/lib/beacon/migration.ex

Line 6 in ffbfb3d

@latest Beacon.Migrations.V001

@leandrocp I did bump this version number, but after that it was only running the v002

@leandrocp
Copy link
Contributor

@leandrocp it looks like Beacon.Migration was only running the migration v001. So I made some adjusts to it

Sorry I forgot to mention you have to bump the version here

beacon/lib/beacon/migration.ex

Line 6 in ffbfb3d

@latest Beacon.Migrations.V001

@leandrocp I did bump this version number, but after that it was only running the v002

Ok let's use V001 for now.

@leandrocp leandrocp merged commit 843dbef into main Jul 12, 2024
3 checks passed
@leandrocp leandrocp deleted the user-def-comps-adjusts-for-ui branch July 12, 2024 16:15
@leandrocp leandrocp mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrocp leandrocp leandrocp approved these changes

Assignees

@alexandrexaviersm alexandrexaviersm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandrexaviersm @leandrocp