Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for LV 1.0 compatibility #682

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Update tests for LV 1.0 compatibility #682

merged 9 commits into from
Dec 4, 2024

Conversation

APB9785
Copy link
Contributor

@APB9785 APB9785 commented Dec 3, 2024

From LV patch notes:

  • Fix live_session not being enforced when patching to the same LiveView under a different route

this means we need to navigate instead of patch when moving between sites

also some renderings now use braces { } instead of the previous HEEx interpolation <%= %> since we use that LiveView rendering engine under the hood

@APB9785 APB9785 marked this pull request as ready for review December 4, 2024 04:02
@APB9785 APB9785 changed the title WIP lv template fixes Update tests for LV 1.0 compatibility Dec 4, 2024
@APB9785 APB9785 merged commit bcf0ec2 into main Dec 4, 2024
3 checks passed
@APB9785 APB9785 deleted the apb/template-fixes branch December 4, 2024 04:07
@APB9785 APB9785 self-assigned this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant