Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload components module after updating #691

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

APB9785
Copy link
Contributor

@APB9785 APB9785 commented Dec 6, 2024

This is a fix for possible site instability after updating a Beacon Component via LiveAdmin

  • Reports of 500 response across the entire site, after making an update to a Beacon Component
  • Seems like the cause is existing templates importing that Component module, which for some reason does not trigger Beacon.ErrorHandler
  • If we find a culprit for ^ this line could be removed again, but for now it prevents the bug from occurring

@APB9785 APB9785 requested a review from leandrocp December 6, 2024 21:31
@APB9785 APB9785 self-assigned this Dec 6, 2024
@APB9785 APB9785 merged commit 801ddc2 into main Dec 9, 2024
3 checks passed
@APB9785 APB9785 deleted the apb/reload-components branch December 9, 2024 19:37
leandrocp added a commit that referenced this pull request Dec 10, 2024
* reload components module after updating

* add note

---------

Co-authored-by: Leandro Pereira <leandro@leandro.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants