fix: boot beacon even without defined beacon_site routes in host app … #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this covers the case of zero sites in the router, but what about cases where 2 sites are started in config, but only 1 is defined in the router? would that still cause the boot to fail? |
APB9785
approved these changes
Dec 11, 2024
yep although needs to verify some other edge case, so merging this one now and I will write a few more tests tomorrow |
leandrocp
added a commit
that referenced
this pull request
Dec 11, 2024
#699) * fix: boot beacon even without defined beacon_site routes in host app router * clean up * docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting a site in the sup tree is not enough, each site must have a corresponding route in the host app's router. But in some cases the route might be missing, which would lead to boot crashes.
Now we're guarding against such scenario and allowing Beacon to boot, but we emit a warning with a link to a troubleshot guide.