Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to save changes after making changes on the visual editor #226

Closed
leandrocp opened this issue Sep 6, 2024 · 2 comments · Fixed by #240
Closed

Failing to save changes after making changes on the visual editor #226

leandrocp opened this issue Sep 6, 2024 · 2 comments · Fixed by #240
Labels
area:visual-editor Impacts Page Visual Editor (Visual Page Builder) bug Something isn't working
Milestone

Comments

@leandrocp
Copy link
Contributor

It doesn't happen every time but to reproduce it you can make some changes on the visual editor then hit Save Changes. Sometimes it will display the success alert but the actual content was not saved. That may happen due to malformed template that we're not validating or some race condition, still needs more investigation.

@leandrocp leandrocp added bug Something isn't working area:visual-editor Impacts Page Visual Editor (Visual Page Builder) labels Sep 6, 2024
@cibernox
Copy link
Collaborator

cibernox commented Sep 6, 2024

If someone can find specific reproduction steps I'll dig into this

@brzpegasus brzpegasus added this to the v0.1.0 milestone Sep 6, 2024
@leandrocp
Copy link
Contributor Author

If someone can find specific reproduction steps I'll dig into this

@cibernox I was not able to reproduce locally but it was reported to happen on our staging env. I don't think the Visual Editor component itself is causing it, but would be helpful if you can help find the root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:visual-editor Impacts Page Visual Editor (Visual Page Builder) bug Something isn't working
Projects
None yet
3 participants