Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ls/Issue 105 persist collapsible state #173

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

swainea
Copy link
Collaborator

@swainea swainea commented Jun 13, 2024

This PR adds the static collapsible state to the sidebar:

sidebar expanded sidebar collapsed
Screenshot 2024-06-13 at 4 27 19 PM Screenshot 2024-06-13 at 4 53 13 PM

UXD will need to work with ENG to complete TODOs

TODO:

  • Toggle expanded / collapsed states with classes (see TODOs in code)
  • Should expanded header include logo and title? We could open another issue for this is not the in scope of v1?
  • Tooltip hover (UXD might be able to do this with Tailwind classes, wanted to see what ENG thinks is best approach)
  • Z-index issue for tooltip (UXD will take a look)

Sorry, something went wrong.

@swainea swainea added the ux Requires UX or UXD label Jun 13, 2024
@swainea swainea marked this pull request as draft June 13, 2024 21:27
@swainea swainea requested a review from leandrocp June 13, 2024 21:27
@swainea swainea mentioned this pull request Jun 14, 2024
@APB9785 APB9785 self-requested a review June 14, 2024 15:16
@swainea swainea changed the title Ls/issue 105 persist collapsible state Ls/Issue 105 persist collapsible state Jun 14, 2024
@APB9785 APB9785 removed their assignment Jun 14, 2024

Verified

This commit was signed with the committer’s verified signature.
leandrocp Leandro Pereira
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux Requires UX or UXD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants