Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Events #50

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Page Events #50

merged 4 commits into from
Aug 15, 2023

Conversation

APB9785
Copy link
Collaborator

@APB9785 APB9785 commented Aug 11, 2023

Resolves #12

@APB9785 APB9785 self-assigned this Aug 11, 2023
@APB9785 APB9785 marked this pull request as ready for review August 14, 2023 20:48
@APB9785 APB9785 requested a review from leandrocp August 14, 2023 20:55
Copy link
Contributor

@leandrocp leandrocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Working great!

@@ -90,6 +90,9 @@ defmodule Beacon.LiveAdmin.AdminComponents do
<li class="mr-2">
<.link patch={beacon_live_admin_path(@socket, @site, "/pages/#{@page_id}/revisions")} class={if(@current_action == :revisions, do: @active_class, else: @regular_class)}>Revisions</.link>
</li>
<li class="mr-2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move "Events" before "Revisions"

@APB9785 APB9785 merged commit 0af5d78 into main Aug 15, 2023
@APB9785 APB9785 deleted the apb/event-handlers branch August 15, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage Page events
2 participants