Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Pages interface #61

Merged
merged 11 commits into from
Oct 17, 2023
Merged

Error Pages interface #61

merged 11 commits into from
Oct 17, 2023

Conversation

APB9785
Copy link
Collaborator

@APB9785 APB9785 commented Aug 23, 2023 •
edited
Loading

Goal

Add an interface for creating, updating, and deleting Beacon Error Pages

Implementation

  • Add Error Pages menu for Beacon sites
  • Similar interface to PageEvents, PageVariants using LiveMonacoEditor

Note

Requires corresponding PR in beacon for new tests to pass

@APB9785 APB9785 self-assigned this Aug 23, 2023
@APB9785 APB9785 marked this pull request as ready for review August 24, 2023 19:01
@APB9785 APB9785 requested a review from leandrocp August 24, 2023 19:01
@leandrocp
Copy link
Contributor

For reference it depends on BeaconCMS/beacon#331

leandrocp
leandrocp requested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@leandrocp leandrocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. It's looking nice.

lib/beacon/live_admin/live/error_page_editor_live/index.ex Outdated Show resolved Hide resolved
@AZholtkevych AZholtkevych linked an issue Aug 28, 2023 that may be closed by this pull request
Page Variants: Error pages #60
Closed
@leandrocp leandrocp merged commit 71028bb into main Oct 17, 2023
3 checks passed
@leandrocp leandrocp deleted the apb/error-pages branch October 17, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrocp leandrocp leandrocp requested changes

Assignees

@APB9785 APB9785

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page Variants: Error pages
2 participants
@APB9785 @leandrocp