Merge pull request #49 from swoolcock/missing-hitsounds

Transfer hitsounds to crafted maps
Beamographic · Aug 19, 2020 · 4a9d9f5 · 4a9d9f5
2 parents b7d4600 + 352b025
commit 4a9d9f5
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/osu.Game.Rulesets.Rush/Beatmaps/RushCraftedBeatmapConverter.cs b/osu.Game.Rulesets.Rush/Beatmaps/RushCraftedBeatmapConverter.cs
@@ -67,7 +67,6 @@ namespace osu.Game.Rulesets.Rush.Beatmaps
     /// 1) Slider velocity and BPM are currently ignored, but may be used in the future
     /// 2) Kiai will be used in the future to indicate boss sections
     /// 3) New combo is ignored
-    /// 4) Hitsounds are only transferred for minions
     /// </remarks>
     public class RushCraftedBeatmapConverter : BeatmapConverter<RushHitObject>
     {
@@ -105,6 +104,7 @@ protected override IEnumerable<RushHitObject> ConvertHitObject(HitObject origina
                         {
                             StartTime = original.StartTime,
                             EndTime = original.GetEndTime(),
+                            Samples = original.Samples,
                             Lane = LanedHitLane.Air
                         };
                     }
@@ -115,6 +115,7 @@ protected override IEnumerable<RushHitObject> ConvertHitObject(HitObject origina
                         {
                             StartTime = original.StartTime,
                             EndTime = original.GetEndTime(),
+                            Samples = original.Samples,
                             Lane = LanedHitLane.Ground
                         };
                     }
@@ -124,7 +125,8 @@ protected override IEnumerable<RushHitObject> ConvertHitObject(HitObject origina
                 case HitObjectType.DualHit:
                     yield return new DualHit
                     {
-                        StartTime = original.StartTime
+                        StartTime = original.StartTime,
+                        Samples = original.Samples,
                     };
 
                     break;
@@ -133,7 +135,8 @@ protected override IEnumerable<RushHitObject> ConvertHitObject(HitObject origina
                     yield return new MiniBoss
                     {
                         StartTime = original.StartTime,
-                        EndTime = original.GetEndTime()
+                        EndTime = original.GetEndTime(),
+                        Samples = original.Samples,
                     };
 
                     break;
@@ -151,7 +154,8 @@ protected override IEnumerable<RushHitObject> ConvertHitObject(HitObject origina
                     yield return new Heart
                     {
                         StartTime = original.StartTime,
-                        Lane = lane
+                        Lane = lane,
+                        Samples = original.Samples,
                     };
 
                     break;