Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ppy.osu.Game from 2022.1022.0 to 2022.1031.0 #273

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 31, 2022

Bumps ppy.osu.Game from 2022.1022.0 to 2022.1031.0.

Release notes

Sourced from ppy.osu.Game's releases.

2022.1031.0

Thanks for following along! This is a tagged release (2022.1031.0). For more information check out the osu! changelog page and dev blog.

Code Quality

Editor

ppy/osu#20850@​peppy)

This is a nuanced detail that hasn't worked correctly since SV was moved to per-object.

A bit of a hard one to explain, but let's try. In osu!stable's editor, slider velocity is factored into distance spacing (so current distance spacing is distance_spacing_multiplier * slider_velocity_from_current_timing_point). Since we moved slider velocity to be attached to hit objects, in lazer it would always take the SV multiplier from the previous hitobject. In the case this was a hit circle, it would not correctly fetch the SV from the last slider.

Rather than make it use the "last slider SV" (which could lead to further complication or confusion), I've opted to remove SV from factoring into distance spacing at all. This means that a mapper may need to manually adjust their distance spacing multiplier when changing slider velocities for a longer section of the beatmap. Maybe better for higher difficulties, but worse for lower? Will be interested to hear feedback on this one.

20850.mp4

ppy/osu-framework#5479@​smoogipoo)

ppy/osu#20914@​peppy)

Note that as per stable, this will result in non-precise distance spacing, as the grid snap is applied as an afterthought.

Add ability to use Shift+Numberppy/osu#20903@​peppy)

20903.mp4

ppy/osu#20901@​peppy)

A bit of a low-effort implementation, but I'd like to push this out and see what kind of feedback mappers have. The implementation in stable is a bit nuanced, and may be preferred in some cases and potentially not in others.

20901.mp4

ppy/osu#20828@​peppy)

Matching osu!stable. I use these quite a lot while mapping and I'm sure others do as well.

Hold Shift = invert grid snap Hold Alt = invert distance snap

20828.mp4

... (truncated)

Commits
  • 4213abf Adjust testflight cleanup interval to 30 days
  • 3f17c20 Update fastlane and dependencies
  • 9ea2bd8 Merge pull request #21018 from andy840119/reuse-the-function-in-timeline-class
  • 93c3bc6 Merge pull request #21020 from peppy/fix-pause-button-interaction
  • 1035b5f Fix hold to pause button not working when HUD is hidden
  • 8399261 Add failing test showing hold for menu not working when HUD is hidden
  • f5e1134 Apply nullability to HUD test scene
  • aa9604c Merge pull request #21014 from Joehuu/fix-toolbar-clock-visual-bug
  • a753369 Reuse function TimeAtPosition() and PositionAtTime().
  • d56786b Fix toolbar visual bug when toggling clock displays
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ppy.osu.Game](https://github.com/ppy/osu) from 2022.1022.0 to 2022.1031.0.
- [Release notes](https://github.com/ppy/osu/releases)
- [Commits](ppy/osu@2022.1022.0...2022.1031.0)

---
updated-dependencies:
- dependency-name: ppy.osu.Game
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 31, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 1, 2022

Superseded by #275.

@dependabot dependabot bot closed this Nov 1, 2022
@dependabot dependabot bot deleted the dependabot/nuget/ppy.osu.Game-2022.1031.0 branch November 1, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants