-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to ensure dict with enum keys are encoded properly #1001
Add test to ensure dict with enum keys are encoded properly #1001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that a good work
758119a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
raised as issue to pydantic |
It's good that you're raising this issue in Pydantic, @07pepa. I appreciate that. This PR, however, is not adding any specific encoding logic to overcome what may be possible Pydantic limitations. It's only adding a test to confirm that the existing Beanie behaviour that had regressed in between 1.23.6 -> 1.24.0 has been fixed. |
actualy this is mistage i was too fast and converted this to draft and comented by mystake lets merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@adeelsohailahmed resolve conficts please |
I don't see any conflicts. |
Thank you for the reviews |
The issue raised in #829 seems to have been fixed in PR #868
beanie/beanie/odm/utils/encoder.py
Lines 134 to 138 in 0b8d50b
Only the relevant test was missing to ensure the regression was adequately addressed. This PR adds that test.