Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UnionDoc type hint missing in init_beanie and on FindInterface #1007

Merged
merged 6 commits into from
Sep 8, 2024
Merged

Fix UnionDoc type hint missing in init_beanie and on FindInterface #1007

merged 6 commits into from
Sep 8, 2024

Conversation

CAPITAINMARVEL
Copy link
Contributor

No description provided.

adeelsohailahmed
adeelsohailahmed reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@adeelsohailahmed adeelsohailahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! I'll give it a more thorough review soon.

adeelsohailahmed
adeelsohailahmed reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@adeelsohailahmed adeelsohailahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

beanie/odm/utils/init.py Outdated Show resolved Hide resolved
@CAPITAINMARVEL
Update init.py
1e0b1f9 
comma missing
adeelsohailahmed
adeelsohailahmed approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@adeelsohailahmed adeelsohailahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adeelsohailahmed adeelsohailahmed merged commit 186650a into BeanieODM:main Sep 8, 2024
19 checks passed
@CAPITAINMARVEL CAPITAINMARVEL deleted the union_doc_fix branch October 5, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayusshsoarav ayusshsoarav ayusshsoarav approved these changes

@adeelsohailahmed adeelsohailahmed adeelsohailahmed approved these changes

@07pepa 07pepa 07pepa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CAPITAINMARVEL @07pepa @adeelsohailahmed @ayusshsoarav