fix return type from document update #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAPITAINMARVEL
requested review from
07pepa,
adeelsohailahmed,
staticxterm,
arunkumarp93,
ritiksoni00,
LawMixer,
ayusshsoarav,
roman-right and
timok19
staticxterm
requested changes
Oct 2, 2024
CAPITAINMARVEL
force-pushed
the
fix_return_type
branch
from
2e262c8
to
811fbaa
Compare
fix type hint
LawMixer
previously approved these changes
Oct 3, 2024
CAPITAINMARVEL
dismissed stale reviews from staticxterm and LawMixer
via
06b6183
LawMixer
approved these changes
Oct 4, 2024
staticxterm
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argument of type "Awaitable[Player]" cannot be assigned to parameter "coro" of type "_CoroutineLike[_T@create_task]" in function "create_task"
"Awaitable[Player]" is not assignable to "Coroutine[Any, Any, _T@create_task]"PylancereportArgumentType
Beanie incorrectly use Awaitable for document set which make raising error on using asyncio create_task