Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests on all major mongo version #1034

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Add tests on all major mongo version #1034

merged 1 commit into from
Oct 2, 2024

Conversation

07pepa
Copy link
Member

@07pepa 07pepa commented Sep 30, 2024 •
edited
Loading

extend testing as far as reasonably possible

@07pepa 07pepa force-pushed the add-tests-on-all-major-mongo-version branch 5 times, most recently from 7c2e156 to 596d5b9 Compare September 30, 2024 17:11
CAPITAINMARVEL
CAPITAINMARVEL reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@CAPITAINMARVEL CAPITAINMARVEL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why specifically 3.12.3 ?

@07pepa
Copy link
Member Author

07pepa commented Oct 1, 2024

Is there a reason why specifically 3.12.3 ?

yes 3.12.4+ will cause pydantic issue with misssing recursion guard and we would need to do biger rewrite of some testing infra see https://github.com/BeanieODM/beanie/actions/runs/11106074398/job/30853640118

Riverfount
Riverfount approved these changes Oct 1, 2024
View reviewed changes
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a great job.

@07pepa 07pepa force-pushed the add-tests-on-all-major-mongo-version branch from 596d5b9 to 7b6a89e Compare October 1, 2024 12:38
@07pepa 07pepa force-pushed the add-tests-on-all-major-mongo-version branch from 7b6a89e to 8402357 Compare October 1, 2024 15:33
@CAPITAINMARVEL CAPITAINMARVEL merged commit 71438c1 into BeanieODM:main Oct 2, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAPITAINMARVEL CAPITAINMARVEL CAPITAINMARVEL approved these changes

@LawMixer LawMixer LawMixer approved these changes

@Riverfount Riverfount Riverfount approved these changes

@adeelsohailahmed adeelsohailahmed Awaiting requested review from adeelsohailahmed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@07pepa @Riverfount @LawMixer @CAPITAINMARVEL