Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing type signature to Document constructor #813

Merged
merged 2 commits into from
Dec 24, 2023
Merged

Add missing type signature to Document constructor #813

merged 2 commits into from
Dec 24, 2023

Conversation

johnthagen
Copy link
Contributor

Closes #812

@johnthagen johnthagen changed the title Add missing type signature to Document constructor Add missing type signature to Document constructor Dec 21, 2023
@roman-right roman-right merged commit 53cf823 into BeanieODM:main Dec 24, 2023
21 checks passed
@roman-right
Copy link
Member

Thank you very much for the PR! Merged

@johnthagen johnthagen deleted the patch-1 branch December 24, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Document constructor fails type check for instantiation with Mypy in strict mode
2 participants
@johnthagen @roman-right