Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-right USERRIGHT_TEXTMESSAGE_USER for allowing private text message #2048

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

bear101
Copy link
Contributor

@bear101 bear101 commented Oct 14, 2023

Server's XML file is automatically converted to allow old users to send text messages.

This fixes #1955

@amirmahdifard
Copy link

@bear101 it is also being said that a user right will be exist to allow channel messages too, but this is only private message: when will you do that one as whel?

@bear101
Copy link
Contributor Author

bear101 commented Oct 15, 2023

@CoBC do you see a need to also be able to block channel text messages? Already there is classroom channels where you can block channel-text messages and also you can password-protect channels.

@bear101 bear101 requested a review from CoBC October 15, 2023 07:18
@bear101
Copy link
Contributor Author

bear101 commented Oct 15, 2023

Also we're running low on bits in UserRight enum

@amirmahdifard
Copy link

@bear101 classroom channels are limitting for only that channel, and emajin that someone took advantij in my server, so i wish to disable their channel messages ability, for every channel, and forever: this is really needed because currently anyway we limit someone, they can still lojicly send channel messages, even when their flud prevention timer had finished.

@beqabeqa473
Copy link
Contributor

beqabeqa473 commented Oct 15, 2023 via email

@amirmahdifard
Copy link

@bear101 ok, so now lets consider everything and then we will see.
if we disable everyone's channel messages in a classroom channel, it disables permenantly, but it does it for everyone and not only that person that we want to disable it for.
if we disable only that person's channel messages, but everyone's channel messages are enabled, if that person logs out and come back the limitation will go away so it doesn't work like that and it's not permanent.
if we password protect channel, that person won't be able to join that channel at all and will still be able to send channel messages to other channels.
if we use flud prevention, they can't send channel messages but only for some amount of time and if that time passes, they can send again, and flud prevention afects everything such as joining channels, leaving, logging in, logging out, so this is also not good way.
so as you can see, the administrator of a server has no way of permanently and definetly disable someones channel messages and they can send channel messages at some point and the admin can't do anything about this case.
so with the things i mentioned here, please add a user right for channel messages as whel, so the user advantij prevention will be complete under administrators hand: we already have prevention of voice, file upload, download, vidio, multy loggin, and all others, so this would complete it.
i guess may be the user right user can change nickname should be removed because it is stupid, user can log out and change their name and log back in again so it does nothing really if you are worryed about running low of user rights

@CoBC
Copy link
Contributor

CoBC commented Oct 15, 2023 via email

@amirmahdifard
Copy link

@bear101 seriously user right of user can change nickname makes no sens for me because i don't know what it is useful for and it doesn't bother people if someone changes their names, and people can change nicknames when they are out of the server and come back, so this is not a prevention really, because the user will still able to do what they want, but only a little difrently: but about other user rights, if you disable them, the user has no way of still doing that until you reenable it back again.

Server's XML file is automatically converted to allow old users to
send text messages.
@bear101 bear101 merged commit 33ae858 into master Oct 15, 2023
11 checks passed
@bear101 bear101 deleted the issue-1955 branch October 15, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User-right for disallowing users to send private and channel messages
4 participants