Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce media file tab for controlling playback #2410

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

bear101
Copy link
Contributor

@bear101 bear101 commented Jul 4, 2024

No description provided.

@bear101
Copy link
Contributor Author

bear101 commented Sep 12, 2024

@CoBC can you take a look and see if there's still many obvious bugs?

@CoBC
Copy link
Contributor

CoBC commented Sep 15, 2024

The volume slider seams to have no effect, when I change his value, it just returns to 1000
Also some QLabel (E.G. format) has no accessible label asociated

@bear101
Copy link
Contributor Author

bear101 commented Sep 17, 2024

@CoBC were you using SpeexDSP when volume had no effect? I've changed volume slider to be disabled if AGC is not enabled in SpeexDSP.

I've also changed the media playback off slider to range from 0-10000 so one can set it more precisely. The best solution would be to change its range depending on the length of the media file.

@CoBC
Copy link
Contributor

CoBC commented Sep 18, 2024

I use TeamTalk Audio preprocessor. Volume slider still seams to have no effect :(, and the "elapsed" slider don't refresh his value, so, when I click on "Play" button, "Elapsed" slider just became active but with a value of 0

@bear101
Copy link
Contributor Author

bear101 commented Sep 18, 2024

If you use the Stream Media file dialog isn't it the same issue with the "Elapsed" slider?

@CoBC
Copy link
Contributor

CoBC commented Sep 18, 2024 via email

@bear101
Copy link
Contributor Author

bear101 commented Sep 27, 2024

@CoBC do the labels have to changed in the same as a "user information dialog" in order to be readable for screen readers?

@CoBC
Copy link
Contributor

CoBC commented Sep 27, 2024 via email

Set C++17 for QtTeamTalk using Qt 5 to allow std::optional.
@bear101 bear101 marked this pull request as ready for review September 28, 2024 07:43
@bear101 bear101 merged commit 95b1b8e into master Oct 1, 2024
11 checks passed
@bear101 bear101 deleted the mediafile-tab branch October 1, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants