Correctly ask for language selection at first start #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When language is initially set, Qt returns language code as something like "fr_FR" for French, so, 9c6970f add a partial check to correctly select languageBox item which is corresponding (E.G. fr for fr_FR) |
bear101
reviewed
Aug 20, 2024
Support partial language name in languageBox selection Also define SETTINGS_GENERAL_FIRSTSTART on macOS
bear101
force-pushed
the
fix_language
branch
from
bc6cde4 to
1034d80
Compare
|
Hm, I'm not having much luck with this change. When I start TeamTalk on macOS then it tells me my system language is English and I choose to continue in English. Then it tell me that it cannot load en_DK. What does that mean? |
|
Hm mainwindow.cpp:893 is not being executed on macOS |
|
I guess mainwindow.cpp:893 should be moved to mainwindow.cpp:848 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrateSettings is call before language selection, if TT has never been started, migrateSettings define a lanauge, so SETTINGS_DISPLAY_LANGUAGE is always set and the language selection isn't trigger.
So, I changed the check to ask for language selection if it is the first startup and not only if SETTINGS_DISPLAY_LANGUAGE isn't present, and I add a check to ensure migrateSettings define a new language only if SETTINGS_DISPLAY_LANGUAGE is previously set.