Qt client: fixed some problems #2528
Conversation
|
@bear101 hi, this pull request is about desktop client as you know, so if you are on desktop clients, merge this please, also, when do you plan to releace 5.18? because currently, people are avoiding to update their teamtalk to 5.17 because it has config upgrade problems, which are resolved in 5.18. So, please make a plan to releace 5.18 at a time, and also merge this pr. Also, befor releacing 5.18, please tell me and give me some time so I can contribute my developments for the android client, so 5.18 android client will also be releaced with fixes and improovments. Thanks. |
|
@bear101 hi again. I'm really sorry. I don't know what are you busy with, but if it is possible for you to merge my prs a bit quicker, i will be thankful to you, And I can open other pull requests. Thanks so much! I'm just asking this because probably in a week or 2, i will travle and don't have access to my computer. Thanks so much! |
|
Enabling and disabling these menu items have nothing to do with security. Security is handled by the server and not which menu items are available on the client side. If you try to list bans and you don't have the right to do it then the server returns and error which is displayed on the client side. I believe you already tried to make these changes before in another PR. |
|
@bear101 yes I know, but up on enabling server banned menu item, it checks if me op, which is incorrect as you know. also, in another prs I enabled intercept options if user is admin and you didn't acsepted so I closed it, but in this pr i didn't add those, I just corrected a fue exsisting ones. |
made sure everything is working properly and as expected