Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titan 18 HX A14V [1822EMS1] #120

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Titan 18 HX A14V [1822EMS1] #120

merged 3 commits into from
Sep 6, 2024

Conversation

glpnk
Copy link
Contributor

@glpnk glpnk commented May 16, 2024

@sempervictus
Copy link
Contributor

Probably a good idea to introduce a "MAYBRICK" danger tag or something like that to help bots which build PRs avoid by tag.

@glpnk
Copy link
Contributor Author

glpnk commented May 19, 2024

I think someone tested this version, but I need to recheck something. Basically, many laptops have similar configs, but some features are unavailable

@sempervictus
Copy link
Contributor

@glpnk - anything i can do to help this PR along?

@glpnk
Copy link
Contributor Author

glpnk commented May 29, 2024

I just need some time to look for it

@glpnk
Copy link
Contributor Author

glpnk commented Jun 3, 2024

Looks like ready, but require checking ability to set keyboard backlight, because some SteelSeries keyboard don't use EC, but MSI program writing dummy values

Thanks for waiting, @Makintos @nalim @sempervictus
Thanks to @Makintos for research

To test:
Download with

git clone -b 1822EMS1 https://github.com/glpnk/msi-ec.git

Make and load

make
sudo make load

@sempervictus
Copy link
Contributor

Seems to work for battery threshold anyway:

# /etc/systemd/system/battery-charge-save-threshold.service
[Unit]
Description=Set the battery charge threshold to max lifetime
After=multi-user.target
StartLimitBurst=0
#Conflicts=battery-charge-full-threshold,battery-charge-balanced-threshold

[Service]
Type=oneshot
Restart=on-failure
ExecStart=/bin/bash -c 'echo min > /sys/devices/platform/msi-ec/battery_mode && echo "Battery charge threshold $(cat /sys/devices/platform/msi-ec/battery_mode)"'

[Install]
WantedBy=multi-user.target

Hasn't blown up my laptop or thrown any errors in compilation using GCC14.1 with pretty much every Grsec/PaX plugin enabled.

@glpnk
Copy link
Contributor Author

glpnk commented Jun 23, 2024

@sempervictus
Have you tested ability to change keyboard brightness from linux?

@sempervictus
Copy link
Contributor

Keyboard brightness works, touchpad fn key does not. Touchpad is actually kind of weird - using libinput with X, i am finding that the "physical click" pressure changes becoming very sensitive to accidental contact when typing and that the "disable touchpad while typing" function in Cinnamon's touchpad settings does not work. Otherwise, super-battery mode, charge adjustment thresholds, keyboard brightness, microphone, fan speed, and volume all work as expected

@glpnk
Copy link
Contributor Author

glpnk commented Jul 13, 2024

@sempervictus

touchpad fn key does not

What? How this look like? And how should work?

How actually super battery works? Is it reduces CPU/GPU speed? Because I'm not have it.

image
Is this really keyboard sized touchpad?

@sempervictus
Copy link
Contributor

Touchpad is about size of space bar integral to the surface. The whole area has mechanical click and it appears to be pressure adjustable but that adjustment sort of swims randomly.
Superbat slows all the chips, kills discrete GPU AFAIK (no idea, can't use nvidia drivers with any form of CFI as they perform function hijacking), and limits fans accordingly. Seems to get about an hour of added life

@glpnk
Copy link
Contributor Author

glpnk commented Jul 13, 2024

Thanks, you probably need to ask community of your touchpad manufacturer, if it is really possible

teackot added a commit that referenced this pull request Sep 6, 2024
@teackot teackot merged commit e5bb920 into BeardOverflow:main Sep 6, 2024
@teackot
Copy link
Collaborator

teackot commented Sep 6, 2024

TODO: docs

@teackot
Copy link
Collaborator

teackot commented Sep 6, 2024

@glpnk we still need to implement those unusual kbd backlight intensity values, right?

@glpnk
Copy link
Contributor Author

glpnk commented Sep 6, 2024

@teackot we just ignore keyboard brightness for RGB and per key RGB keyboards, value in EC just cycles and MSI app receive key press events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants