-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MSI Modern 15 A5M (155LEMS1.106) support #66
Conversation
Add Needs testing:
|
@glpnk Hi! How much time do you need to check and accept this pull request? I can't understand what flow is at your repo, half year gone, but pull request is still marked as draft. |
Hi, I think we're still here #83 (comment) . Only I'm a computer geek, I don't know how to finish the job. Indeed, having compatibility with the Modern 15 A5M would be ideal, and it seems that many users are interested on this particular laptop given the previous posts shared on the forum for this specific platform. Until the work is finished, thanks for the effort and attention already put into the project. |
@lmaxyz Does all features from draft are working? I can't accept PR because I'm not maintainer. @benitozh From the checklist you linked in the comment, it looks like all the main functions are supported, but:
Anyone has Windows to test @teackot What do you think about this issue? |
@glpnk Thanks for letting me know. I'm actually using Win11, and will try eventually to test the designated value while adjusting fan speed for F4. |
@benitozh Thanks for your effort. Can you explain how you managed to fix RWEverything? Please check other settings inside You don't need to change settings in fan curve mode, just enable it. Cooler boost seems default I think fan modes are similar on modern series laptops, so .fan_mode = {
+++ .address = 0xf4,
.modes = {
+++ { FM_AUTO_NAME, 0x0d },
+++ { FM_SILENT_NAME, 0x1d },
--- { FM_BASIC_NAME, 0x4d },
+++ { FM_ADVANCED_NAME, 0x8d },
MSI_EC_MODE_NULL
},
}, |
Hello, I was able to fix the problem I was facing when launching RWEverything by applying the method explained in this post, modifying a value in my computer's registry to support the application's driver. After consulting the parameters proposed in the High Performance mode, the "auto" mode is selected by default, with the option of replacing it with the cooler booster mode. Here's a screenshot of the values obtained by activating the cooler booster mode. --> As asked, the custom fan curve with default parameters enabled : Finally, I can't say for sure whether the address you're referring to comes from #4, but if it does, it seems valid in the sense of the post written by @BeardOverflow #4 (comment) |
@benitozh So fan modes are similar to other "modern" models, and you have second ("dGPU") fan, but don't have dGPU, only in-CPU video. (please reply/dislike if I wrong or like if true) My thoughts from comment above now confirmed. |
Hi @glpnk, indeed the A5M model has two fans, and no discrete video card but only one integrated in the CPU (R5 5500u). Is there anything else that needs to be done so that the msi-ec driver can support our laptop ? |
@benitozh Thanks again, I think we done. @teackot We need to remove .fan_mode = {
+++ .address = 0xf4,
.modes = {
+++ { FM_AUTO_NAME, 0x0d },
+++ { FM_SILENT_NAME, 0x1d },
--- { FM_BASIC_NAME, 0x4d },
+++ { FM_ADVANCED_NAME, 0x8d },
MSI_EC_MODE_NULL
},
}, |
Awesome, can't wait to get my hands back on Arch :) |
Hi there, just quick question : is there a scheduled time until this repo get merged with the main msi-ec branch ? Thanks :) EDIT : Hi @BeardOverflow, @teackot could you please merge this fork to the main msi-ec branch in order to get our laptop MSI Mordern 15 A5M working with the your driver ? We're still standing by since early december. Thanks in advance :) |
Hi guys! Is repository maintainer here? Can somebody merge the PR? @teackot , I see you are active on github. Do you have contact information to contact @BeardOverflow . I think he dropped repository maintaining and we should contact him somehow. |
Hi, @lmaxyz I haven't been active in this project for some time because of my university and got out of the loop. And then didn't have enough motivation to process everything that happened while I was away, I'm trying to get back to maintaining it though. I'll look through this PR once I get home in a couple of hours, thanks for the bump! |
Finally! |
I have this AUR package fork https://github.com/quaresmajose/msi-ec-dkms-git witch is working pretty well using the dkms. |
Hi there :) However, while the coolerboost function activates correctly when I change the appropriate file to on or off, the fan-mode function doesn't seem to respond to changing the value in the Perhaps I've missed something important? I'd like your opinion on this. Thanks in advance for your answers! |
Hi @benitozh and thanks for your advice! I'll try it later. What about fans. I think you should try to use |
@benitozh Hi! Have you tried watching the fan speed on fresh boot, in case it is because of some background processes or your DE/WM? My fans, for example, work much more when I use Gnome, even on fresh boot. Also, try the "silent" option - the fans should probably work quieter and/or less often. |
It worked ! Thanks for your advice, i literally didn't think to change the value in the shift_mode folder in a first place. I'm still a newbie in there but I'm learning a lot thanks to you all. |
@benitozh Glad to help you) |
No description provided.