Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part of #3708: array_api to call functions from arkouda.pdarray_crea… #3758

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Part of #3708: array_api to call functions from arkouda.pdarray_crea… #3758

merged 1 commit into from
Oct 25, 2024

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Sep 9, 2024 •
edited
Loading

Part of #3708: array_api to call functions from arkouda.pdarray_creation

Refactors:

  • creation_functions.py
  • elementwise_functions.py
  • linalg.py

@ajpotts ajpotts force-pushed the 3708-array_api-to-call-functions-from-arkouda.pdarray_creation branch 2 times, most recently from 58ad8d1 to ac22c11 Compare September 10, 2024 15:27
@ajpotts ajpotts marked this pull request as ready for review September 10, 2024 15:27
@ajpotts ajpotts force-pushed the 3708-array_api-to-call-functions-from-arkouda.pdarray_creation branch from 35e3464 to f4a657c Compare September 10, 2024 16:52
@ajpotts ajpotts marked this pull request as draft September 11, 2024 18:32
@ajpotts ajpotts marked this pull request as ready for review September 11, 2024 18:39
@ajpotts ajpotts force-pushed the 3708-array_api-to-call-functions-from-arkouda.pdarray_creation branch 2 times, most recently from 13daecf to ae606c8 Compare September 18, 2024 13:54
@ajpotts ajpotts force-pushed the 3708-array_api-to-call-functions-from-arkouda.pdarray_creation branch 3 times, most recently from a256c3b to 85ed5be Compare September 19, 2024 13:27
@ajpotts ajpotts marked this pull request as draft September 20, 2024 14:24
@ajpotts ajpotts force-pushed the 3708-array_api-to-call-functions-from-arkouda.pdarray_creation branch 2 times, most recently from eb5e533 to c4641ff Compare September 20, 2024 20:01
@ajpotts ajpotts marked this pull request as ready for review September 20, 2024 20:02
stress-tess
stress-tess approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks amanda!

@stress-tess stress-tess added this pull request to the merge queue Oct 9, 2024
jeremiah-corrado
jeremiah-corrado approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor issue with the linear algebra changes:

arkouda/array_api/linalg.py Show resolved Hide resolved
arkouda/array_api/linalg.py Show resolved Hide resolved
@stress-tess stress-tess removed this pull request from the merge queue due to a manual request Oct 9, 2024
@ajpotts ajpotts force-pushed the 3708-array_api-to-call-functions-from-arkouda.pdarray_creation branch 2 times, most recently from 44a5234 to 7263d23 Compare October 10, 2024 23:59
@ajpotts ajpotts force-pushed the 3708-array_api-to-call-functions-from-arkouda.pdarray_creation branch 3 times, most recently from 5d8d8ea to e412199 Compare October 25, 2024 15:28
@ajpotts
Copy link
Contributor Author

ajpotts commented Oct 25, 2024

I had to remove the broadcast from matmul to account for this bug: #3871

@ajpotts ajpotts force-pushed the 3708-array_api-to-call-functions-from-arkouda.pdarray_creation branch from e412199 to 4c00a96 Compare October 25, 2024 15:29
@stress-tess stress-tess added this pull request to the merge queue Oct 25, 2024
Merged via the queue into Bears-R-Us:master with commit 6b6e2d6 Oct 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaketrookman jaketrookman jaketrookman approved these changes

@jeremiah-corrado jeremiah-corrado jeremiah-corrado approved these changes

@stress-tess stress-tess stress-tess approved these changes

@drculhane drculhane Awaiting requested review from drculhane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajpotts @stress-tess @jeremiah-corrado @jaketrookman