Closes #3283: histogram2d between different dtypes #3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
approved these changes
Sep 18, 2024
jaketrookman
force-pushed
the
hist2d
branch
from
d4024b7
to
3fa18fd
Compare
stress-tess
reviewed
Sep 18, 2024
| @@ -61,7 +61,7 @@ module Histogram | |||
| return hist; | |||
| } | |||
|
|
|||
| proc histogramGlobalAtomic(x: [?aD] ?etype, y: [aD] etype, xMin: etype, xMax: etype, yMin: etype, yMax: etype, numXBins: int, numYBins: int, xBinWidth: real, yBinWidth: real) throws { | |||
| proc histogramGlobalAtomic(x: [?aD] ?etype1, y: [aD] ?etype2, xMin: etype1, xMax: etype1, yMin: etype2, yMax: etype2, numXBins: int, numYBins: int, xBinWidth: real, yBinWidth: real) throws { | |||
| const totNumBins = numXBins * numYBins; | |||
| var hD = makeDistDom(totNumBins); | |||
| var atomicHist: [hD] atomic int; | |||
There was a problem hiding this comment.
all the other atomicHist were turned into real, should this one be too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (Closes #3283) by adding mixed types to work with histogram2d and matches the result dtypes with Numpy.