Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OperatorMsg #3773

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jeremiah-corrado
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado commented Sep 13, 2024

Refactor operatorMsg to use instantiateAndRegister.

Because binary operations have traditionally not supported uint(8), a separate parameter-class is added with all the scalar types except uint(8).

Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
@jeremiah-corrado jeremiah-corrado changed the title use instantiateAndRegister for binopvv Refactor OperatroMsg Sep 16, 2024
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
@jeremiah-corrado jeremiah-corrado changed the title Refactor OperatroMsg Refactor OperatorMsg Sep 17, 2024
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
@jeremiah-corrado jeremiah-corrado marked this pull request as ready for review September 17, 2024 16:09
Copy link
Contributor

@ajpotts ajpotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! It's so much easier to read now.

src/OperatorMsg.chpl Show resolved Hide resolved
src/OperatorMsg.chpl Outdated Show resolved Hide resolved
src/OperatorMsg.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
src/BinOp.chpl Outdated Show resolved Hide resolved
@jeremiah-corrado
Copy link
Contributor Author

jeremiah-corrado commented Sep 18, 2024

The // " comments were put there intentionally to work around a bug in the syntax highlighter I'm using (it fails to recognize the closing quote in "%"). I'm happy to remove them if you think they're more annoying than helpful though.

Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
@stress-tess
Copy link
Member

The // " comments were put there intentionally to work around a bug in the syntax highlighter I'm using (it fails to recognize the closing quote in "%"). I'm happy to remove them if you think they're more annoying than helpful though.

I think that's a good reason to leave it. If you feed so inclined, you could make them like:

// " <- quote is workaround for syntax highlighter bug

but I don't think it's super necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants