Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3722: Remove @arkouda.registerND from SortMsg.chpl #3780

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Sep 19, 2024

Closes #3722: Remove @arkouda.registerND from SortMsg.chpl

@ajpotts ajpotts force-pushed the 3722-Remove-@arkouda.registerND-from-SortMsg.chpl branch from 9e7915e to 2f58564 Compare September 19, 2024 16:29
@ajpotts ajpotts marked this pull request as ready for review September 19, 2024 16:33
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Couple of things that could be simplified:

src/SortMsg.chpl Outdated Show resolved Hide resolved
src/SortMsg.chpl Outdated Show resolved Hide resolved
@ajpotts ajpotts force-pushed the 3722-Remove-@arkouda.registerND-from-SortMsg.chpl branch from b57710e to 8471af1 Compare September 19, 2024 19:22
@ajpotts ajpotts force-pushed the 3722-Remove-@arkouda.registerND-from-SortMsg.chpl branch from 8471af1 to 07fe429 Compare September 20, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove @arkouda.registerND from SortMsg.chpl.
2 participants