Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different version if Revise is tracking proto #36

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

Tortar
Copy link
Contributor

@Tortar Tortar commented Feb 19, 2024

Alternative to #35. Look at https://discourse.julialang.org/t/is-there-a-way-to-know-if-revise-is-enabled/110379/6 for the limitations. Thanks to @Eben60 for the most part of the implementation (need to add him as a coauthor at least). It works fine on my machine

Fixes #13
Closes #35

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (df875e2) 97.50% compared to head (5bd48de) 91.72%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/ProtoStruct.jl 42.85% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   97.50%   91.72%   -5.78%     
==========================================
  Files           2        2              
  Lines         120      133      +13     
==========================================
+ Hits          117      122       +5     
- Misses          3       11       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Eben60 <61665180+Eben60@users.noreply.github.com>
@Tortar
Copy link
Contributor Author

Tortar commented Feb 19, 2024

I think this one can be merged @BeastyBlacksmith without problems because it doesn't change the interface

Copy link
Owner

@BeastyBlacksmith BeastyBlacksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a big fan of wrapping structs in modules for this. In theory this should't be necessary with this approach.
On the other hand I don't use Revise, so I trust you here.

@BeastyBlacksmith BeastyBlacksmith merged commit c8345eb into BeastyBlacksmith:master Feb 19, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with using Revise
2 participants