Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed replayer attempting to update energy before the first note event. #148

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fixed replayer attempting to update energy before the first note event. #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Source/2_Core/Replayer/Emulation/Scoring/ReplayerScoreProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ static void ConvertAndAddSliderData(SliderData sliderData, ICollection<NoteData>
private static bool _lastCutIsGood;
private static float _lastCutBeforeCutRating;
private static float _lastCutAfterCutRating;
private static LinkedListNode<NoteEvent> _lastNoteEvent = null!;
private static LinkedListNode<NoteEvent>? _lastNoteEvent;

private void SimulateNoteWasCut(NoteEvent noteEvent, bool isGoodCut) {
if (!SetupEmulator(noteEvent)) return;
Expand Down Expand Up @@ -326,6 +326,7 @@ private static void GoodCutScoringInitPostfix(GoodCutScoringElement __instance)
}

private static void NoteWasProcessedPostfix(GameEnergyCounter __instance) {
if (_lastNoteEvent == null) return;
var currentTime = _lastNoteEvent.Value.eventTime;
var prevTime = _lastNoteEvent.Previous?.Value.eventTime ?? 0;
var nextTime = _lastNoteEvent.Next?.Value.eventTime ?? 0;
Expand Down
Loading