Fixed crash on log out/log in after soft restart

BeatLeader · Apr 29, 2024 · 6c7da46 · 6c7da46
1 parent 469ec38
commit 6c7da46
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/assets/bl.bundle b/assets/bl.bundle
diff --git a/src/UI/LeaderboardUI.cpp b/src/UI/LeaderboardUI.cpp
@@ -233,6 +233,8 @@ namespace LeaderboardUI {
     }
 
     void updatePlayerInfoLabel() {
+        if (uploadStatus == NULL) return;
+
         auto const& player = PlayerController::currentPlayer;
         if (player != std::nullopt) {
             if (!player->name.empty()) {

diff --git a/src/UI/PreferencesViewController.cpp b/src/UI/PreferencesViewController.cpp
@@ -198,16 +198,6 @@ void BeatLeader::PreferencesViewController::DidActivate(bool firstActivation, bo
             });
         });
 
-        auto capturethis = this;
-        PlayerController::playerChanged.emplace_back([capturethis](std::optional<Player> const& updated) {
-            if (!capturethis->isActivated) return;
-            BSML::MainThreadScheduler::Schedule([updated] {
-                if (updated) {
-                    UpdateUI(updated);
-                }
-            });
-        });
-
         saveToggle = AddConfigValueToggle(containerTransform, getModConfig().SaveLocalReplays);
         starsDropdown = AddConfigValueDropdownEnum(containerTransform, getModConfig().StarValueToShow, starValueOptions);
         // // After switching the setting we need to manually call refresh, because StandardLevelDetailView::RefreshContent is not called again,