Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support for very old Python versions #259

Closed
orbeckst opened this issue Sep 16, 2023 · 0 comments · Fixed by #265
Closed

drop support for very old Python versions #259

orbeckst opened this issue Sep 16, 2023 · 0 comments · Fixed by #265
Assignees
@orbeckst
Labels
Python3
Milestone
1.0.0

Comments

@orbeckst
Copy link
Member

orbeckst commented Sep 16, 2023 •
edited
Loading

GromacsWrapper has been supporting legacy Python for a long time (2.7, <3.7... arguable 3.7 and 3.8 are also old) and in principle we could continue to do so. However, it becomes increasingly complex to manage the testing of the old versions so we will retire support for Python 2.7 and <3.7 ≤3.7 in the next release.

GW 0.8.5 #256 is the last release that supports the full range of Python versions.
@orbeckst orbeckst mentioned this issue Sep 16, 2023
Closed
4 tasks
@orbeckst orbeckst added this to the 1.0.0 milestone Sep 16, 2023
@orbeckst orbeckst mentioned this issue Nov 8, 2023
Merged
@orbeckst orbeckst mentioned this issue Nov 8, 2023
Merged
@orbeckst orbeckst self-assigned this Nov 8, 2023
orbeckst added a commit that referenced this issue Nov 8, 2023
@orbeckst
removed support for Python <= 3.7 (#265)
51e1a03 
* close #259 
* removed support for Python <= 3.7
  - removed six and replaced with Python 3.x constructs
  - updated package meta data
  - update installation docs (sphinx and README)
  - updated CHANGES
* switch to testing GROMACS 2023.1 for all Python
  Only use other GROMACS versions for spot testing at highest supported Python.
  Note that we now have failures of GROMACS 2021.1 with macOS Python 3.11.
* changed macOS CI runner
  - only explicitly include one macOS runner at the latest supported Python
  - downgrade GROMACS to 2018.6 bioconda to avoid failing tests because later
    GROMACS releases were compiled to use  rdtscp CPU instruction but these
    are not available on GitHub runners and lead to failing tests)
    (2021.3-bioconda, 2020.6 conda-forge, 2021.1 from bioconda (which worked
    previously!),  2020.5 bioconda, 2019.5 bioconda all failed with the same error
    that RDTSCP information was not available in the macOS runner)
  - also output CPU information: /proc/cpuinfo or sysctl -a
orbeckst added a commit that referenced this issue Nov 9, 2023
@orbeckst
updated CI environments
49d51a0 
- remove six from all environments (should have been in PR #265,
  part of #259)
- add sphinx_rtd_theme to the RTD CI as it is apparently no longer
  installed automatically by RTD. (fix #267)
@orbeckst orbeckst mentioned this issue Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orbeckst orbeckst

Labels
Python3
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

removed support for Python <= 3.7 Becksteinlab/GromacsWrapper
1 participant
@orbeckst