Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch no filename test #73

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Switch no filename test #73

merged 1 commit into from
Jul 22, 2024

Conversation

IAlibay
Copy link
Collaborator

@IAlibay IAlibay commented Jul 22, 2024

Fixes #72

MMTF is deprecated and fetch_mmtf no longer works. This just switches the test to using an in-memory GRO file and then setting the filename to None.

@IAlibay IAlibay requested a review from orbeckst July 22, 2024 04:18
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (febb3a8) to head (30aa754).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files           2        2           
  Lines          59       59           
=======================================
  Hits           58       58           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orbeckst orbeckst merged commit ca280be into main Jul 22, 2024
21 checks passed
@orbeckst orbeckst deleted the remove-mmtf-test branch July 22, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail for MDAKit registry check
2 participants