Implement reset() method in StatsdDataCollector #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After upgrade to Symfony 3.4, there is a deprecation error caused by this class: > Implementing "Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface" without the "reset()" method is deprecated since Symfony 3.4 and will be unsupported in 4.0 for class "M6Web\Bundle\StatsdBundle\DataCollector\StatsdDataCollector" This PR introduces what the deprecation notice asks for.
Oliboy50
approved these changes
Jan 16, 2018
| { | ||
| $this->statsdClients = []; | ||
| $this->data['clients'] = []; | ||
| $this->data['operations'] = 0; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
please remove those unneeded spaces here
| /** | ||
| * Reset the data collector to initial state | ||
| */ | ||
| public function reset() | ||
| { | ||
| $this->statsdClients = []; | ||
| $this->data['clients'] = []; | ||
| $this->data['operations'] = 0; |
There was a problem hiding this comment.
could you please write the reset function content this way:
$this->statsdClients = [];
$this->data = [
'clients' => [],
'operations' => 0,
];as re-instanciating the whole data property is how we already did the reset() stuff in our other projects ( such as AmqpBundle or CassandraBundle )
Oliboy50
approved these changes
Jan 17, 2018
gbouyge
approved these changes
Jan 17, 2018
|
Travis build was failing due to a down time on their side, I've restart it and now it's all green. I merge your PR and tag the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrade to Symfony 3.4, there is a deprecation error caused by this class:
This PR introduces what the deprecation notice asks for.