-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated on tree builder root #70
Conversation
composer.json
Outdated
@@ -17,6 +17,7 @@ | |||
}, | |||
"require": { | |||
"php": "^7.1.3", | |||
"symfony/config": "^4.2", | |||
"symfony/property-access": "^3.4 || ^4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"symfony/property-access": "^3.4 || ^4.0", | |
"symfony/property-access": "^4.0", |
let's also remove support for symfony 3.4 here, we'll bump a new major release anyway
to make the CI build pass, we will have to tell travis
to also stop building using SYMFONY_VERSION: 3.4
...
I'd suggest to use SYMFONY_VERSION: 4.4
to be prepared for symfony 5
I've rebased and updated a few things after the merge of #75 which drop support for everything below symfony 4.4 |
thank you 👌 => https://packagist.org/packages/m6web/statsd-bundle#v4.0.0 |
Fix the following deprecation :
See https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Config/Definition/Builder/TreeBuilder.php#L30