Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated on tree builder root #70

Merged
merged 5 commits into from
Jul 26, 2020

Conversation

maximecolin
Copy link
Contributor

Fix the following deprecation :

A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0.

The "Symfony\Component\Config\Definition\Builder\TreeBuilder::root()" method called for the "m6_statsd" configuration is deprecated since Symfony 4.3, pass the root name to the constructor instead.

See https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Config/Definition/Builder/TreeBuilder.php#L30

@Oliboy50 Oliboy50 mentioned this pull request Feb 16, 2020
composer.json Outdated
@@ -17,6 +17,7 @@
},
"require": {
"php": "^7.1.3",
"symfony/config": "^4.2",
"symfony/property-access": "^3.4 || ^4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"symfony/property-access": "^3.4 || ^4.0",
"symfony/property-access": "^4.0",

let's also remove support for symfony 3.4 here, we'll bump a new major release anyway

to make the CI build pass, we will have to tell travis to also stop building using SYMFONY_VERSION: 3.4...
I'd suggest to use SYMFONY_VERSION: 4.4 to be prepared for symfony 5

@Oliboy50 Oliboy50 mentioned this pull request Jul 5, 2020
@Oliboy50
Copy link
Member

I've rebased and updated a few things after the merge of #75 which drop support for everything below symfony 4.4

@Oliboy50 Oliboy50 merged commit e125929 into BedrockStreaming:master Jul 26, 2020
@Oliboy50
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants