fix: cast the replaced value as string #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentin-claras
requested changes
Aug 1, 2023
| @@ -16,14 +16,14 @@ | |||
| class ConsoleListener | |||
| { | |||
| /** @var EventDispatcherInterface */ | |||
| protected $eventDispatcher = null; | |||
| protected $eventDispatcher; | |||
There was a problem hiding this comment.
You should update line 67 to check with isset
There was a problem hiding this comment.
To be honest, I trusted blindly the cs-fixer. Thank you.
|
|
||
| /** | ||
| * Time when command started | ||
| * | ||
| * @var float | ||
| */ | ||
| protected $startTime = null; | ||
| protected $startTime; |
There was a problem hiding this comment.
If for some reason onException or onTerminate are called before onCommand we will get an exception (L.76) because startTime will not have been set. We should check if startTime is set before dispatching.
There was a problem hiding this comment.
I am struggling with the cs-fixer. I initialized these vars inside the constructor
valentin-claras
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On PHP8.1 when a value is an object, str_replace failed because of the type checking.
As a solution, we can cast the value returned by the propertyAccessor.
I also apply cs-fix to make the CI green 🤷♂️