Mobility Atomization 7: Crit Status and Succumbing alert #10900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
atomization of #8965
Further contributes to the removal of update_mobility():
InFullCritical()
. We already have standardized stat checks as UNCONSCIOUS or SOFTCRIT, etc. So this snowflaking made no sense.InFullCritical()
Ports:
Why It's Good For The Game
Cleanup of stat code, furthering progress of removing update_mobility.
I also think the alert has twofold benefits, both preventing accidental death when the player is just trying to whisper, and making it less ambiguous to admins when a player is salt ghosting while in crit (i.e. to prevent capture via xenos)
Testing Photographs and Procedure
Screenshots&Videos
Blind vision working
dreamseeker_36MnlDST1D.mp4
Succumbing
dreamseeker_zmca2mmsOj.mp4
Changelog
🆑 rkz, Mothblocks, Ryll/Shaps
add: Adds new succumb HUD alert upon crit status. Replaces the old "Whisper to die" system.
refactor: Refactored stat system to check hardcrit directly
fix: fixed stat handling to utilize new hardcrit check, reducing duplicate code
/:cl: