Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobility Atomization 7: Crit Status and Succumbing alert #10900

Merged
merged 5 commits into from
Apr 28, 2024

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Apr 18, 2024

About The Pull Request

atomization of #8965

Further contributes to the removal of update_mobility():

  • Adds an extra stat define for checking hardcrit/fullcrit, rather than relying on a proc InFullCritical(). We already have standardized stat checks as UNCONSCIOUS or SOFTCRIT, etc. So this snowflaking made no sense.
  • Adds new trait to replace indirect non-stat usages of InFullCritical()
  • Fixes a few weird checks, now that we can properly determine a carbon being either in soft or hard crit status.
  • Adds a new succumb alert. Removes whispering whilst in crit killing the user, instead "Last Words" are done through the alert.

Ports:

Why It's Good For The Game

Cleanup of stat code, furthering progress of removing update_mobility.

I also think the alert has twofold benefits, both preventing accidental death when the player is just trying to whisper, and making it less ambiguous to admins when a player is salt ghosting while in crit (i.e. to prevent capture via xenos)

Testing Photographs and Procedure

Screenshots&Videos

Blind vision working

dreamseeker_36MnlDST1D.mp4

Succumbing

dreamseeker_zmca2mmsOj.mp4

Changelog

🆑 rkz, Mothblocks, Ryll/Shaps
add: Adds new succumb HUD alert upon crit status. Replaces the old "Whisper to die" system.
refactor: Refactored stat system to check hardcrit directly
fix: fixed stat handling to utilize new hardcrit check, reducing duplicate code
/:cl:

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, needs to get in before it skews

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Apr 28, 2024
Merged via the queue into BeeStation:master with commit 6644ae0 Apr 28, 2024
8 checks passed
DrDuckedGoose pushed a commit to DrDuckedGoose/BeeStation-Hornet that referenced this pull request May 11, 2024
DrDuckedGoose pushed a commit to DrDuckedGoose/BeeStation-Hornet that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants