Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes it so the Aetherwhisp lasers have circuit boards and don't get deleted upon deconstruction. #2612

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

Bobbanz1
Copy link
Contributor

@Bobbanz1 Bobbanz1 commented Mar 5, 2024

About The Pull Request

This PR Fixes #2581
It does this by giving the phaser weapons circuit boards alongside stock parts required to construct them, I'm all ears for feedback as to what would be a fair amount of required components for them but currently they have the following requirements:

Laser AMS:

  • 5 Sheets of Glass
  • 5 Micro Lasers
  • 5 Capacitors
  • 5 Power Cells
  • 5 Bluespace Crystals

Phase Cannon:

  • 5 Sheets of Glass
  • 5 Micro Lasers
  • 5 Capacitors
  • 5 Power Cells
  • 5 Bluespace Crystals

Burst Phasers:

  • 3 Sheets of Glass
  • 3 Micro Lasers
  • 3 Capacitors
  • 3 Power Cells
  • 3 Bluespace Crystals

Why It's Good For The Game

The ability to keep the round from having to end due to the phaser weapons being unable to be reconstructed the second they get destroyed is quite the good thing I would say.

Testing Photographs and Procedure

Screenshots&Videos

Phase Cannon
Skärmbild 2024-03-05 100743

Laser AMS (Board is now named laser AMS to shorten the lengthy name for the board down)
Skärmbild 2024-03-05 100718

Burst Phasers
Skärmbild 2024-03-05 100645

Changelog

🆑
add: Gave the Aetherwhisp laser weaponry circuit boards so they don't get completely round removed when destroyed,
/:cl:

@Pockets-byte
Copy link
Contributor

it would be very nice if at the least the tier of parts affected the LAMS, because the roundstart LAMS, is... ineffective

@Bokkiewokkie Bokkiewokkie added Fix Munitions Issues and pull requests related to munitions. Active Test Merge labels Mar 8, 2024
Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Bokkiewokkie
Copy link
Contributor

it would be very nice if at the least the tier of parts affected the LAMS, because the roundstart LAMS, is... ineffective

We can add this later too, for now the main concern is being able to rebuild them

@Bokkiewokkie Bokkiewokkie merged commit e69abca into BeeStation:master Mar 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Active Test Merge Fix Munitions Issues and pull requests related to munitions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aetherwhisp phaser doesn't deconstruct properly
3 participants