Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another few random fixes #2634

Merged
merged 1 commit into from
May 19, 2024
Merged

Conversation

DeltaFire15
Copy link
Contributor

About The Pull Request

Went to fix one annoying runtime, found more while debugging as it goes.
See changelog or code for what exactly.

Why It's Good For The Game

Fix man good.

Testing Photographs and Procedure

image

Changelog

🆑
fix: Overmap projectiles should no longer runtime during collisions while in the process of being fired.
fix: Explosions no longer try to throw qdeleting objects.
fix: The admin ghost checking proc no longer cries if it is passed a non-mob.
fix: The ship console references on overmaps now have some slightly more sane reference handling.
/:cl:

small fix because this loves being an issue when I test combat. :)

also more random fixes because they popped up while debugging.
Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on those ship computer destructions, I now notice I've been sleeping on the possible saboteur tactic of building a random helm console and destroying it in the middle of combat to disconnect the ship's pilot

@Bokkiewokkie Bokkiewokkie added Fix Overmap This issue or PR is related to overmap interactions Runtime Runtime Errors labels May 1, 2024
@DeltaFire15
Copy link
Contributor Author

DeltaFire15 commented May 1, 2024

Obviously nobody could ever think of making a second console of any type!
(That reminds me I need to look at the exploit of astrometrics stacking sometime..)

@Bokkiewokkie
Copy link
Contributor

Obviously nobody could ever think of making a second console of any type! (That reminds me I need to look at the exploit of astrometrics stacking sometime..)

(My ass spawning a starmap console in maints to look at it as an admin before we had the starsys manager)

@Bokkiewokkie Bokkiewokkie merged commit bc9635d into BeeStation:master May 19, 2024
9 checks passed
@DeltaFire15 DeltaFire15 deleted the impactedfix branch June 15, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Active Test Merge Fix Overmap This issue or PR is related to overmap interactions Runtime Runtime Errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants