Achievement stuff #2690
Merged
Achievement stuff #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaFire15
added
Config Update
Fix
Overmap
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
I love conflicts caused by formatting! |
fixes a race-condition induced issue and also improves perf a tiny bit.
small fix because for some reason apparently I missed a single dist() call instead of overmap_dist() back when I reworked overmap singularities.
Bokkiewokkie
approved these changes
Sep 26, 2024
ss13-beebot
added a commit
that referenced
this pull request
Sep 26, 2024
IndusRobot
pushed a commit
to IndusRobot/NSV13
that referenced
this pull request
Dec 16, 2024
IndusRobot
pushed a commit
to IndusRobot/NSV13
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
We have some custom NSV achievements that have been broken for a long while (if they ever worked)
This fixes them and or makes them work in the first place.
Also adds a bunch of new achievements that fit NSV, aswell as a score counter for people making torpedoes the old fashioned way.
I don't have a database setup so I can't actively test this too much, but it compiles and should work.
Also now fixes a single
dist()call in overmap singularities that should beovermap_dist()Modifies star system config. If this PR is merged or testmerged, the star_system default json must be updated to the one provided here (or manually compared). You must also either reset the persistent json, or update the values of the systems changed here manually (two values in total, so should be managable)
Why It's Good For The Game
A sense of pride and accomplishment for completing objectives.
Changelog
🆑
fix: The NSV-specific achievements should work now.
add: Some more NSV-specific achievements.
fix: Replaced a dist call for overmap singularities with the proper version.
/:cl: