Fixes the "You are Dead" tgui window popup #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bokkiewokkie
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Title.
At the moment, it shows up but is never properly cleared because usually client is already null when the ghost's logout is called, and even if it wasn't that would be a bad place to clear it.
This moves the procs to clear that message to revival, ghost grabbing, and the mob Login() proc, the latter two only being triggered if the mob is actually alive, which should be much more reliable.
Why It's Good For The Game
Fix man good.
Changelog
🆑
fix: The "You are Dead" chat window popup should now be properly removed when you are not dead.
/:cl: