Fixes overmap loop homing #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a thing and highlights an issue with something else (we'll figure out what to do with that!)
DeltaFire15
added
Fix
Overmap
Bokkiewokkie
approved these changes
Oct 11, 2024
ss13-beebot
added a commit
that referenced
this pull request
Oct 18, 2024
IndusRobot
pushed a commit
to IndusRobot/NSV13
that referenced
this pull request
Dec 16, 2024
IndusRobot
pushed a commit
to IndusRobot/NSV13
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Essentially, homing projectiles on the overmap didn't take into account the z looping.
This makes them do that. Will probably never be free of running across things not yet configured for
overmap_angle()&overmap_dist()Also noticed something else broken but for now that's just getting annotation until I actually discuss it.
Why It's Good For The Game
Fix man good.
Testing Photographs and Procedure
I'm not recording a video for this but it does do the thing on local.
Changelog
🆑
fix: Overmap projectiles now correctly home across z loop borders.
/:cl: