Check for empty Tag filter string #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `filterString` in `TagFilter` is an empty string, an exception was being thrown because the code was expecting a non-empty string. This checks if the string is non-empty and returns early if it is. Issue: Behat#250
stof
reviewed
Apr 26, 2022
strlen is O(1) and mb_strlen is O(n).
stof
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
filterStringinTagFilteris an empty string, an exceptionwas being thrown because the code was expecting a non-empty string.
This checks if the string is non-empty and returns early if it is.
Issue: #250