-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to phpunit 10 #275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @uuf6429 this looks generally good, a couple of comments
@@ -7,7 +7,7 @@ | |||
use Behat\Gherkin\Parser; | |||
use PHPUnit\Framework\TestCase; | |||
|
|||
abstract class FilterTest extends TestCase | |||
abstract class AbstractFilterTestBase extends TestCase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our own projects we've gone with xxTestCase
to follow the TestCase
base class naming of phpunit, but I think AbstractXXXTestBase
is also fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I like -TestCase better, I'll go for that.
d07d2ba
to
3ba83e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 😀
Motivation:
AbstractFilterTestBase
andAbstractKeywordsTestBase
were renamed due to the aforementioned phpunit change. I picked that name because:Abstract-
puts the class on top of the file list and immediately gives the impression of an abstract class-Base
is specifically the fix for the problem of ending with-Test
Alternative ideas for a name are of course welcome.Renamed to
-TestCase
instead, since it feels more natural.