Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to phpunit 10 #275

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Upgrade to phpunit 10 #275

merged 1 commit into from
Dec 9, 2024

Conversation

uuf6429
Copy link
Contributor

@uuf6429 uuf6429 commented Dec 7, 2024

Motivation:

AbstractFilterTestBase and AbstractKeywordsTestBase were renamed due to the aforementioned phpunit change. I picked that name because:

  • Abstract- puts the class on top of the file list and immediately gives the impression of an abstract class
  • -Base is specifically the fix for the problem of ending with -Test

Alternative ideas for a name are of course welcome.

Renamed to -TestCase instead, since it feels more natural.

This was referenced Dec 7, 2024
Copy link
Contributor

@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @uuf6429 this looks generally good, a couple of comments

@@ -7,7 +7,7 @@
use Behat\Gherkin\Parser;
use PHPUnit\Framework\TestCase;

abstract class FilterTest extends TestCase
abstract class AbstractFilterTestBase extends TestCase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our own projects we've gone with xxTestCase to follow the TestCase base class naming of phpunit, but I think AbstractXXXTestBase is also fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I like -TestCase better, I'll go for that.

@uuf6429 uuf6429 force-pushed the chore/upgrade-phpunit branch from d07d2ba to 3ba83e7 Compare December 9, 2024 20:45
@uuf6429 uuf6429 requested review from acoulton and stof December 9, 2024 20:47
Copy link
Contributor

@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😀

@stof stof merged commit a114b77 into Behat:master Dec 9, 2024
6 checks passed
@uuf6429 uuf6429 deleted the chore/upgrade-phpunit branch December 10, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants