Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses the test container if exists #139

Merged
merged 1 commit into from
Apr 20, 2018

Conversation

sroze
Copy link
Contributor

@sroze sroze commented Apr 8, 2018

In Symfony 4.1, we (actually, @nicolas-grekas) added the ability to get private services from the container (symfony/symfony#26499). We need to leverage this within Behat's extension.

@sroze sroze force-pushed the uses-test-container-if-exists branch from 2eef810 to d9d389c Compare April 8, 2018 18:24
@jakzal
Copy link
Contributor

jakzal commented Apr 20, 2018

👍

@sroze sroze merged commit d7c8344 into Behat:master Apr 20, 2018
@sroze sroze deleted the uses-test-container-if-exists branch April 20, 2018 15:48
@OskarStark
Copy link

@sroze could you please create a release?

@pamil
Copy link
Member

pamil commented Jun 6, 2018

It's introducing a same BC break in this extension - symfony/symfony#27494.

@sroze
Copy link
Contributor Author

sroze commented Jun 6, 2018 via email

@stof
Copy link
Member

stof commented Jun 6, 2018

for anyone using a custom container based class for their main container, the container injected here is not the custom one anymore (as it is the test container).

So we would have to expose this in a different way

@stof
Copy link
Member

stof commented Jun 6, 2018

actually, as it is used only in the argument resolver, I don't think it suffers from the BC break

@pamil
Copy link
Member

pamil commented Jun 6, 2018

Yeah, if it's used as only as an argument resolver, then it wouldn't be a BC break indeed.

@OskarStark
Copy link

so a release could be done, as it is no BC break?

@OskarStark
Copy link

ping @sroze

@sroze
Copy link
Contributor Author

sroze commented Jun 8, 2018

Released in 2.1.5.

@OskarStark
Copy link

Thank you 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants