-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses the test container if exists #139
Conversation
2eef810
to
d9d389c
Compare
👍 |
@sroze could you please create a release? |
It's introducing a same BC break in this extension - symfony/symfony#27494. |
What do you mean?
…On Wed, Jun 6, 2018 at 7:55 AM Kamil Kokot ***@***.***> wrote:
It's introducing a same BC break in this extension - symfony/symfony#27494
<symfony/symfony#27494>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#139 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxHEVLHubp1j4xCLR4zgMSPb74Ot_ODks5t53z-gaJpZM4TLozw>
.
|
for anyone using a custom container based class for their main container, the container injected here is not the custom one anymore (as it is the test container). So we would have to expose this in a different way |
actually, as it is used only in the argument resolver, I don't think it suffers from the BC break |
Yeah, if it's used as only as an argument resolver, then it wouldn't be a BC break indeed. |
so a release could be done, as it is no BC break? |
ping @sroze |
Released in 2.1.5. |
Thank you 🎉 |
In Symfony 4.1, we (actually, @nicolas-grekas) added the ability to get private services from the container (symfony/symfony#26499). We need to leverage this within Behat's extension.