This repository has been archived by the owner on Apr 20, 2021. It is now read-only.
Fix array parameters #280
Closed
Fix array parameters #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YoannChabert , Are you still working on this ? Can you make the tests green ? If you don't have the time, I can have a look at it. |
|
@raoulclais all is green now :) now we just have to wait @sanpii review |
|
@sanpii do you have some time to review this ? |
Simperfit
approved these changes
Mar 6, 2020
|
any news ? @sanpii |
|
Would be great to have this feature merged 🚀 Any plans to merge it @sanpii ? |
|
The only thing I see is that it could be improved slightly to handle files as well, otherwise great work 👍 |
|
I still need this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix a BC break with sending POST request with array #261 & #264