Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbelafull : a complete bela lib #626

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

TheTechnobear
Copy link
Contributor

@TheTechnobear TheTechnobear commented Apr 20, 2020

libbelafull - a library (so,a) with all bela objects within it

contains build/.o + libraries//build/*.o

addresses #624

@giuliomoro
Copy link
Contributor

giuliomoro commented May 20, 2020

Thanks for your patiences.

I picked some of your changes:

gitignore (++) 5609ad4
Salt delay time 83d7f31

Additionally, I added hooks for inserting your own makefile, at the top and/or the bottom of the main one: 74eb2a5
I am therefore not going to get your changes about libbelafull, as you can add it to your CustomMakefileBottom.in.

I will review the pepper changes: I want to test what is going on with the button service requiring restart.

@giuliomoro
Copy link
Contributor

Just to clarify, with the current master branch, one can create two files in the Bela folder:

CustomMakeFileTop.in with the following content:

NO_PROJECT_TARGETS+=lib/libbelafull.a libbelafull

CustomMakefileBottom.in with the following content:

LIB_FULL_A = libbelafull.a
LIB_FULL_OBJS = build/*/*.o libraries/*/build/*.o

lib/$(LIB_FULL_A): $(LIB_FULL_OBJS) $(PRU_OBJS) $(LIB_DEPS)
	$(AT) echo Building lib/$(LIB_FULL_A)
	$(AT) ar rcs lib/$(LIB_FULL_A) $(LIB_FULL_OBJS)

libbelafull: lib/libbelafull.a

and they will then be able to call make libbelafull

@adrianduke
Copy link

@giuliomoro I've just tested your suggestion and I haven't found a way to make it work, the problem stems from sub-makefiles not being able to export variables back up to parents, see: https://stackoverflow.com/questions/31414456/sub-makefiles-and-passing-variables-upward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants