Comments and Clean Up #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sorry, haven't looked as this repo in awhile (been stable for my needs). Will look at the PR in depth in a bit; I agree with the forks, and definitely alot of room for improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very large diff. I'm not really expecting a merge as-is. I can do another request with fewer changes if you like. (Maybe removing the TODO comments.) Mainly I want to get your opinion on the direction I'm modifying the code - Are you likely to merge the changes I'd like to make? I don't want to end up with yet another separately maintained copy of this tool.
Here's a summary of the changes so far: