Improve formatting of relative times #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the display of relative times. With the current code, a operation that starts in 4 minutes 59 seconds from now is reported to start in "4 minutes". An operation starting in 1 day 23 hours is reported to start in "1 day". This leads to confusion about when the event actually starts. Using Carbon's time rounding, we now display more intuitive relative distances. Closes BenHUET#49
This prevents listing ongoing events as "ended 1 second ago" when they are actually still active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the display of relative times. With the current code, a operation that starts in 4 minutes 59 seconds from now is reported to start in "4 minutes". An operation starting in 1 day 23 hours is reported to start in "1 day". This leads to confusion about when the event actually starts. Using Carbon's time rounding, we now display more intuitive relative distances.
Closes #49