Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes bowtie2-build TypeError in PyPy #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nellore
Copy link

@nellore nellore commented Mar 4, 2018

This is a band-aid for an error encountered when at least one version of PyPy is the default version of Python:

bowtie2-build --version
Traceback (most recent call last):
  File "/home/travis/build/nellore/rail/src/bowtie2/bowtie2-build", line 86, in <module>
    main()
  File "/home/travis/build/nellore/rail/src/bowtie2/bowtie2-build", line 83, in main
    subprocess.call(argv)
  File "/opt/python/pypy2.7-5.8.0/lib-python/2.7/subprocess.py", line 168, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/opt/python/pypy2.7-5.8.0/lib-python/2.7/subprocess.py", line 340, in __init__
    if args[1:] in (
TypeError: deque[:] is not supported

@junaruga
Copy link
Contributor

junaruga commented Sep 16, 2018

In my opinion, the challenge of this repository is this repository can need test cases on at least Python3, and optionally PyPy3, and PyPy. Currently used Python is Python 2.7 as a default setting of Travis CI.

I prepared the example in my bowtie2 repository.
The Travis results: https://travis-ci.org/junaruga/bowtie2/builds/429289751
My repository's "feature/ci-pyhon" branch: https://github.com/junaruga/bowtie2/tree/feature/ci-pyhon
The modification: junaruga@2827319

This modification can be after the PR: #207 , because I changed .travis.yml to use matrix/include for that.

In the case there are 5 test cases.
Maybe we can prepare very light weight test to only check validation of python script such as make python-test, because make allall && make simple-test is very heavy.

References
https://docs.travis-ci.com/user/languages/python/#pypy-support
https://github.com/pypa/pip/blob/18.0/.travis.yml#L31-L40

@junaruga
Copy link
Contributor

junaruga commented Mar 18, 2019

@nellore It seems the pull-request was merged at 57b6091 .

@junaruga
Copy link
Contributor

junaruga commented Apr 4, 2019

I think this issue was fixed at this commit.
57b6091
We can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants