Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ID_Soll_BWS_akt for hot water target temperature #305

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blue-bean
Copy link

Using ID_Soll_BWS_akt for hot water target temperature
See #280

Using ID_Soll_BWS_akt for hot water target temperature
Copy link

@Alkaramazov Alkaramazov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nice

@Alkaramazov
Copy link

Tested on 2025.1.4-Beta
HA Core 2025.1.1
HA Supervisor 2024.12.3

It works correctly

@BenPru
Copy link
Owner

BenPru commented Jan 22, 2025

@blue-bean Is this working for all Firmware Versions?
Please provide a changelog Text.

@colognebroker
Copy link

For me it is not working with V3.90.2-12457 firmware and also. not for 3.90.3

@blue-bean
Copy link
Author

For me it is not working with V3.90.2-12457 firmware and also. not for 3.90.3

Which version of HA and which version of this integration? How did you the changes described in my commit?

@rhammen
Copy link
Contributor

rhammen commented Jan 28, 2025

I refer to my comment on Oct 22, 2024 in #280:

"So with FW3.79, still ID_Einst_BWS_akt needs to be used (as does the 2024.10.5-Beta luxtronik integration)
This means any change in the integration to use ID_Soll_BWS_akt instead of the currently used ID_Einst_BWS_akt should be firmware version dependant (>= .90)"

In your commit, I see that you simply change the target parameter to ID_Soll_BWS_akt where it currently is ID_Einst_BWS_akt.
I do not see the target parameter being a firmware dependant?
That means this PR will break the integration for users who are not on FW 3.90.x !

Fixing the problem for some users and at the same time breaking it for others is not the way forward.
So please implement a FW dependant setting, as that apparently is what is needed now since the Luxtronik FW versions require different target parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants