feat(media): add more supported file extensions

closes #45
BenShelton · Jun 8, 2021 · b1862c0 · b1862c0
1 parent 19086dc
commit b1862c0
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 8 deletions.
diff --git a/packages/media/app/main/src/ipc.ts b/packages/media/app/main/src/ipc.ts
@@ -14,6 +14,7 @@ import {
 } from '@library-api/core'
 import { MediaDetailsDTO } from '@library-api/core/types/dto'
 
+import { imageExtensions, videoExtensions } from 'shared/extensions'
 import { initDirectories } from './directories'
 import { getControlWindow, getDisplayWindow } from './window'
 import { CATALOG_PATH, DOWNLOAD_DIR, VIDEO_DIR } from './constants'
@@ -151,7 +152,13 @@ export function initIPC (): void {
       title: 'Choose the media you want to display',
       defaultPath: app.getPath('downloads'),
       filters: [
-        { name: 'Media', extensions: ['jpg', 'png', 'gif', 'mp4', 'avi'] }
+        {
+          name: 'Media',
+          extensions: [
+            ...imageExtensions,
+            ...videoExtensions
+          ]
+        }
       ]
     })
     if (canceled || !filePaths.length) return false

diff --git a/packages/media/app/renderer/src/pages/Display.vue b/packages/media/app/renderer/src/pages/Display.vue
@@ -30,6 +30,8 @@
 <script lang="ts">
 import { defineComponent, ref } from 'vue'
 
+import { imageExtensions, videoExtensions } from 'shared/extensions'
+
 import { DisplayMedia, DisplayClear } from 'shared/types/ipc'
 
 export default defineComponent({
@@ -43,15 +45,12 @@ export default defineComponent({
         mediaType.value = 'image'
       } else {
         const ext = args.src.split('.').pop()
-        switch (ext) {
-          case 'jpg':
-          case 'png':
-          case 'gif':
+        if (ext) {
+          if (imageExtensions.includes(ext)) {
             mediaType.value = 'image'
-            break
-          case 'mp4':
-          case 'avi':
+          } else if (videoExtensions.includes(ext)) {
             mediaType.value = 'video'
+          }
         }
       }
       src.value = args.src

diff --git a/packages/media/app/shared/extensions.ts b/packages/media/app/shared/extensions.ts
@@ -0,0 +1,16 @@
+export const imageExtensions = [
+  'jpg', 'jpeg',
+  'gif',
+  'png',
+  'bmp',
+  'svg',
+  'webp',
+  'ico'
+]
+
+export const videoExtensions = [
+  'mp4', 'm4p', 'm4v',
+  'ogg',
+  'mov',
+  'webm'
+]